Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cortex 2020 Annual Review #394

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Conversation

gouthamve
Copy link
Contributor

Signed-off-by: Goutham Veeramachaneni [email protected]

Signed-off-by: Goutham Veeramachaneni <[email protected]>
@amye
Copy link
Contributor

amye commented Mar 31, 2020

@cncf/toc - we have our first annual review in! Any questions?

@quinton-hoole
Copy link
Contributor

Is this a self-review by the Cortex team?

I think it would be useful for the newly-formed cncf-sig-observability to take a look and comment.

cc @halcyondude @raravena80

@sheng-liang
Copy link

Agreed @quinton-hoole . SIG observability please take a look.

@sheng-liang sheng-liang added the tag-observability things related to SIG-Observability label Apr 4, 2020
@amye
Copy link
Contributor

amye commented Apr 10, 2020

No, removing SIG-Observability per Annual Review documentation:

The outcome of the annual review is either:

At least three (two before the TOC grows to 11 members) TOC members agree to continue to sponsor the project in Sandbox, or
If enough TOC members don’t agree to continue to sponsor the project, we will discuss archiving or other next steps with you.
Additionally, the TOC might recommend that you apply for Incubation stage. This requires extra work and due diligence so it’s not a possible outcome directly from this lightweight annual review.


SIGs do not need to review annual reviews, this is TOC only.

@amye amye added annual review and removed tag-observability things related to SIG-Observability labels Apr 10, 2020
@amye amye added this to Submitted in Sandbox Annual Reviews May 7, 2020
@alena1108
Copy link
Contributor

LGTM for Sandbox Annual Review

@gouthamve
Copy link
Contributor Author

Hi @amye and @alena1108 for the update! I am a little confused about the last update, does this mean the TOC has completed the annual review for Cortex?

Does the TOC has any feedback? Is there anything we could do as a team to help?

Thanks,
Goutham.

@alena1108
Copy link
Contributor

@gouthamve per https://github.com/cncf/toc/blob/415a62d03547a6008a222ed194ecd0530fe53d1a/process/sandbox-annual-review.md#review-outcomes, 3 TOC members should agree to support the project by putting LGTM to PR. I was the first one, 2 more votes are needed.

I wanted to highlight 3 things done well:

  1. Documentation https://cortexmetrics.io. - easy to follow and navigate.
  2. Release management. A couple of things that can be improved in Release Notes documentation, to make it more concise and easy to read:
  • Would make sense to move Config file breaking changes to its own separate document. And in general avoid putting too much detail to the release notes. Just a short bug description is enough, the details can be listed in the corresponding bug. This way it's a bit easier to read, and understand the release scope.

  • Group enhancements/feature/change and Bug fixes in separate categories to avoid [FEATURE]/[BUG FIX] prefixes

  1. Section on comparison with Thanos is very useful.

Note that the project's request for incubation will be reviewed separately.

@amye amye moved this from Submitted to 1 TOC Sponsor in Sandbox Annual Reviews May 21, 2020
@RichiH
Copy link
Contributor

RichiH commented May 26, 2020

As a data point, SIG o11y accepted the DD documentation and will suggest moving Cortex to incubation stage: #315 (comment)

@lizrice
Copy link
Contributor

lizrice commented Jun 1, 2020

Also LGTM for Sandbox Annual Review

@amye amye moved this from 1 TOC Sponsor to 2 TOC Sponsors in Sandbox Annual Reviews Jun 1, 2020
@kgamanji
Copy link
Contributor

kgamanji commented Jun 3, 2020

LGTM for annual review

@amye amye moved this from 2 TOC Sponsors to Complete in Sandbox Annual Reviews Jun 3, 2020
@amye amye merged commit 19dba0b into cncf:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

8 participants