Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Japanese version definition #193

Merged
merged 2 commits into from
Feb 16, 2019
Merged

Added Japanese version definition #193

merged 2 commits into from
Feb 16, 2019

Conversation

yokawasa
Copy link

@yokawasa yokawasa commented Feb 2, 2019

  • Added Japanese version
  • Added TOC for non English versions

@dankohn
Copy link
Contributor

dankohn commented Feb 2, 2019

Thanks for this. We'll review and approve soon.

dankohn
dankohn reviewed Feb 2, 2019
View reviewed changes
DEFINITION.md Outdated Show resolved Hide resolved
Update DEFINITION.md
fc1314d 
Added an explanation for additional language versions
@dankohn
Copy link
Contributor

dankohn commented Feb 2, 2019

Thanks. I'm awaiting review from @nfukuyasu who represents the Linux Foundation in Japan. I'm looking forward to displaying your text at CNCF's booth at the Open Source Summit Tokyo in July. https://events.linuxfoundation.org/events/open-source-summit-japan-2019/

@dankohn
Copy link
Contributor

dankohn commented Feb 16, 2019

@nfukuyasu was very complimentary on the quality of your translation. Thank you!

@dankohn dankohn merged commit 3cd76cf into cncf:master Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dankohn dankohn dankohn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yokawasa @dankohn