Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add openkruise lfx idea #1286

Merged
merged 3 commits into from
Aug 2, 2024
Merged

add openkruise lfx idea #1286

merged 3 commits into from
Aug 2, 2024

Conversation

furykerry
Copy link
Contributor

@furykerry furykerry commented Jul 30, 2024

Term 03 - 2024 September - October

Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @furykerry!

Could @zmberg, @ringtail, and @chrisliu1995 provide a 👍 or approve this PR to confirm participation?

@nate-double-u
Copy link
Member

nate-double-u commented Jul 31, 2024

[edit]: comment removed, thanks for reaching out @chrisliu1995!

@nate-double-u
Copy link
Member

We're still waiting for a confirmation (👍 or PR approve) from @ringtail to confirm participation before we can merge this in.

@ringtail
Copy link

ringtail commented Aug 2, 2024

Thanks @nate-double-u

@furykerry
Copy link
Contributor Author

@nate-double-u it seems that the branch has conflicts, do I need to rebase the patch ?

Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see everyone has confirmed, thanks!

@furykerry, it was an easy conflict to merge so I just went ahead and did it.

I think LFX approvals may be a couple days b/c the approvers are in a timezone that's heading into the weekend now. I'll load this into the platform, but approvals may take til Monday.

@nate-double-u nate-double-u merged commit 6471b9c into cncf:main Aug 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants