Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pod lifecycle events project #1279

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SergeyKanzhelev
Copy link
Contributor

xlink: kubernetes/kubernetes#126369

I will try to find out if anybody from SIG Docs can help. I have limited knowledge of hugo and automation possible on website.

@satyampsoni
Copy link

I think @sftim @nate-double-u or @divya-mohan0209 can help.

@nate-double-u
Copy link
Member

nate-double-u commented Jul 26, 2024

Hi @SergeyKanzhelev, thanks for this!

Since this is a proposal for a Kubernetes project, we'll also need the approval of the sig-contribex leads. Usually, we'd require a project maintainer's approval, but things are a bit different with K8s projects and subprojects. I believe the chairs are currently: @kaslin & @palnabarun, if you could both take a look 🙂

I'd also like to wait for the upstream issue to get triaged before we accept this (I expect this is part of why this is a WIP proposal 🙂).

When it comes time, could @tallclair provide a 👍 or approve this PR to confirm participation?

@SergeyKanzhelev
Copy link
Contributor Author

/assign @tallclair

@nate-double-u definitely will contact contribex leads, I was not sure what the process is =).

@kaslin
Copy link

kaslin commented Jul 26, 2024

Within Kubernetes, we don't require any review @nate-double-u. We confirmed this in slack with a past project lead and our mentoring subproject lead (@jberkus). That said, we're happy to review if folks want us to.

@kaslin
Copy link

kaslin commented Jul 26, 2024

Looks Good to Me 👍

@nate-double-u
Copy link
Member

nate-double-u commented Jul 26, 2024

Within Kubernetes, we don't require any review @nate-double-u. We confirmed this in slack with a past project lead and our mentoring subproject lead (@jberkus). That said, we're happy to review if folks want us to.

The request is more for the CNCF mentorship admins—usually, we require a maintainer to approve an LFX mentorship proposal before accepting it. In the case of Kubernetes, the project structure is much more complex, so we landed on asking for sig-contribex chairs to play the approver role. It's a way of confirming that the project approves of the work being done (and, by extension, agrees that the money spent would be worthwhile).

So, I very much appreciate you doing the reviews!

@jberkus
Copy link
Collaborator

jberkus commented Jul 29, 2024

/approve

@nate-double-u
Copy link
Member

This is still set to WIP, and I'm still looking for a 👍 or approval from @tallclair to confirm their participation.

The PR was opened before the due date, so don't worry about not getting this merged before today. Even if it's a couple days late we can load this into the LFX platform but it may have to go in on the second pass (which means it may miss being available for the first day or 2 of candidate applications).

@SergeyKanzhelev SergeyKanzhelev force-pushed the podlifecycleevents branch 2 times, most recently from 847d3a4 to 2ea84a9 Compare July 30, 2024 18:03
@SergeyKanzhelev SergeyKanzhelev changed the title [WIP] pod lifecycle events project pod lifecycle events project Jul 30, 2024
@SergeyKanzhelev
Copy link
Contributor Author

This is still set to WIP, and I'm still looking for a 👍 or approval from @tallclair to confirm their participation.

@tallclair is out of office till Monday, but I promise he signed up for this with me. I don't want to expose Tim's email without his confirmation. Would it be ok to keep it as TODO till Monday?

@nate-double-u
Copy link
Member

Monday is OK.

@tallclair
Copy link

Sorry for the delay. Yes, Sergey and I discussed this offline. 👍 from me.

@SergeyKanzhelev SergeyKanzhelev force-pushed the podlifecycleevents branch 2 times, most recently from 4d1c62f to 068fb8e Compare August 5, 2024 17:02
@SergeyKanzhelev
Copy link
Contributor Author

@nate-double-u this is ready to be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

7 participants