Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server: fix unbound exception variable #1051

Merged
merged 1 commit into from
Jan 14, 2023
Merged

Server: fix unbound exception variable #1051

merged 1 commit into from
Jan 14, 2023

Conversation

dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Dec 8, 2022

Small accident, quick fix. Likely gets caught somewhere else anyway, but better to be explicit.

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

An exception variable got unbound, even though it is used.

@dshemetov dshemetov requested a review from rzats December 8, 2022 23:05
@melange396
Copy link
Collaborator

getting to this line doesnt seem likely to happen in production but leaving it as-is could be problematic and produce strange artifacts in logging and for the client, so im going to merge it back in for the next release.

@melange396 melange396 merged commit 94ec8e9 into dev Jan 14, 2023
@melange396 melange396 deleted the ds/fix-exception branch January 14, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants