Bug fix with ordinal loading in remote processes #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a good catch, thanks! Before I accept the pull request, could you please increment the version number contained in the scripts header comments from version 1.2 to 1.3? |
|
Incremented the version number. Thanks for the quick response and for the pull |
clymb3r
added a commit
that referenced
this pull request
Dec 29, 2014
Bug fix with ordinal loading in remote processes. Thanks to sixdub for finding & fixing the bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing remote loading of a DLL that had imports using ordinals, the code would crash prompting that NumBytesWritten was undefined. NumBytesWritten is properly defined in the logical case that a name is used but not an ordinal (line 1327). Added a definition of NumBytesWritten directly above the place where the error was occurring which then fixed the bug.
