skynet.wait中使用的session增加回绕判断 #1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudwu
reviewed
May 27, 2024
lualib/skynet.lua
Outdated
| @@ -158,15 +164,26 @@ do ---- avoid session rewind conflict | |||
| return session | |||
| end | |||
|
|
|||
| local function auxwait_checkrewind() | |||
| local session = c.genid() | |||
| if session and session > dangerzone_low and session <= dangerzone_up then | |||
There was a problem hiding this comment.
此处可以稍微修改一下，不需要判断 session 为 nil 的情况，可以把判断次数减少到两次。因为：
https://github.com/cloudwu/skynet/blob/master/lualib-src/lua-skynet.c#L228-L234
genid 一定会返回数字（不会出错），而之前两处类似的地方都可能返回 nil （通常是出错）。
cloudwu
pushed a commit
that referenced
this pull request
Jun 23, 2024
* skynet.wait中使用的session增加回绕判断 * 去除session判空 --------- Co-authored-by: mippo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1930