New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skynet.call, skynet.rawcall 修改建议 #190

Closed

Jexocn opened this issue Oct 28, 2014 · 3 comments

Contributor

Jexocn commented Oct 28, 2014

通过 skynet.call, skynet.rawcall 与不存在(或未启动)的服务地址通信, send 会返回0, 导致协程挂起,不出错也不返回, 后续逻辑不好处理, 建议 send 返回的 session 为 0 时, 直接 error

Owner

cloudwu commented Oct 28, 2014

目前就是抛出异常的:

https://github.com/cloudwu/skynet/blob/master/lualib/skynet.lua#L410-L412

cloudwu closed this as completed

Contributor Author

Jexocn commented Oct 28, 2014

实际测试,并未抛出异常
https://github.com/cloudwu/skynet/blob/master/lualib/skynet.lua#L409-L409
会返回 0, 而不是 nil
跟踪了一下代码
https://github.com/cloudwu/skynet/blob/master/lualib-src/lua-skynet.c#L192-L196
https://github.com/cloudwu/skynet/blob/master/skynet-src/skynet_server.c#L689-L695
或许要改一下这里
https://github.com/cloudwu/skynet/blob/master/skynet-src/skynet_server.c#L689-L695

cloudwu added a commit that referenced this issue


fix issue #190

954625a

Owner

cloudwu commented Oct 28, 2014

做了一点小修改, 现在目标服务不存在的异常可以跨节点传回了.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment