ConfigHelper is replace by a facade pattern

cloudtrends · Mar 16, 2015 · 0a95c44 · 0a95c44
1 parent 4cfe2a3
commit 0a95c44
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 40 deletions.
diff --git a/core/src/com/cloud/agent/resource/virtualnetwork/ConfigHelper.java b/core/src/com/cloud/agent/resource/virtualnetwork/ConfigHelper.java
diff --git a/core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java b/core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
@@ -49,6 +49,7 @@
 import com.cloud.agent.api.routing.GetRouterAlertsCommand;
 import com.cloud.agent.api.routing.GroupAnswer;
 import com.cloud.agent.api.routing.NetworkElementCommand;
+import com.cloud.agent.resource.virtualnetwork.facade.AbstractConfigItemFacade;
 import com.cloud.utils.ExecutionResult;
 import com.cloud.utils.NumbersUtil;
 import com.cloud.utils.exception.CloudRuntimeException;
@@ -325,7 +326,14 @@ public boolean connect(final String ipAddress, int retry, int sleep) {
  }
 
  private List<ConfigItem> generateCommandCfg(NetworkElementCommand cmd) {
- return ConfigHelper.generateCommandCfg(cmd);
+ /*
+ * [TODO] Still have to migrate LoadBalancerConfigCommand and BumpUpPriorityCommand
+ * [FIXME] Have a look at SetSourceNatConfigItem
+ */
+
+ final AbstractConfigItemFacade configItemFacade = AbstractConfigItemFacade.getInstance(cmd.getClass());
+
+ return configItemFacade.generateConfig(cmd);
  }
 
  private Answer execute(AggregationControlCommand cmd) {