Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove github_token from codebuild #113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

gweecl
Copy link

@gweecl gweecl commented Jun 30, 2023

what

Remove github_token from codebuild module

why

  • github_oauth_token causing conflict between codepipeline and codebuild where
    • In codepipeline, its used as a REAL github token value for Codepipeline Source config
    • In codebuild, its used as parameter store name
  • codebuild module is not creating the parameter store resources, hence causing err during codebuild stage
    Phase context status code: Decrypted Variables Error Message: parameter does not exist: YOUR_GITHUB_TOKEN
    
  • If github_token is needed, can manually put in using environment_variables variable

references

@gweecl gweecl requested review from a team as code owners June 30, 2023 03:10
@hans-d
Copy link

hans-d commented Mar 2, 2024

/terratest

@hans-d hans-d added the stale This PR has gone stale label Mar 2, 2024
@hans-d
Copy link

hans-d commented Mar 3, 2024

@gweecl Hi, can you update the pr so that it passes the tests? otherwise, it is likely to be closed due to staleness.

@mergify mergify bot added triage Needs triage and removed stale This PR has gone stale labels Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants