Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates next/image import to dist path #388

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Updates next/image import to dist path #388

merged 1 commit into from
Dec 22, 2023

Conversation

colbyfayock
Copy link
Collaborator

Description

Attempting to fix import issue in Pages router with suggested workaround for ESM projects: vercel/next.js#54777 (comment)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Fix or improve the documentation
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

@vercel Vercel
Copy link

vercel bot commented Dec 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
next-cloudinary ✅ Ready (Inspect) Visit Preview Dec 22, 2023 4:01pm

@colbyfayock colbyfayock merged commit 59ad1ff into beta Dec 22, 2023
7 checks passed
@colbyfayock colbyfayock deleted the beta+bug/387 branch December 22, 2023 16:03
github-actions bot pushed a commit that referenced this pull request Dec 22, 2023
@semantic-release-bot
chore(release): 5.17.0-beta.1 [skip ci]
b1cb251 
# [5.17.0-beta.1](v5.16.0...v5.17.0-beta.1) (2023-12-22)

### Features

* Updates next/image import to dist path ([#388](#388)) ([59ad1ff](59ad1ff)), closes [/github.com/vercel/next.js/issues/54777#issuecomment-1808505837](https://github.com//github.com/vercel/next.js/issues/54777/issues/issuecomment-1808505837)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 5.17.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@colbyfayock