[RFC0028] Enable using protected CNBs #3855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modulo11
force-pushed
the
cnb-protected-buildpacks
branch
3 times, most recently
from
000999b
to
035baf5
Compare
pbusko
reviewed
Jun 20, 2024
modulo11
force-pushed
the
cnb-protected-buildpacks
branch
from
035baf5
to
9ab08c6
Compare
nicolasbender
force-pushed
the
cnb-protected-buildpacks
branch
from
a45ce11
to
4e3382a
Compare
pbusko
force-pushed
the
cnb-protected-buildpacks
branch
from
a3d1a1d
to
33625e7
Compare
Co-authored-by: Johannes Dillmann <[email protected]> Co-authored-by: Ralf Pannemans <[email protected]> Co-authored-by: Nicolas Bender <[email protected]>
Co-authored-by: Pavel Busko <[email protected]> Co-authored-by: Nicolas Bender <[email protected]>
pbusko
force-pushed
the
cnb-protected-buildpacks
branch
from
33625e7
to
22696f4
Compare
| { | ||
| name: 'some-name', | ||
| relationships: { space: { data: { guid: space.guid } } }, | ||
| lifecycle: { type: 'cnb', data: { buildpacks: ['http:https://buildpack.com'], credentials: { registry: { user: 'password' } } } } |
There was a problem hiding this comment.
Suggested change
| lifecycle: { type: 'cnb', data: { buildpacks: ['http:https://buildpack.com'], credentials: { registry: { user: 'password' } } } } | |
| lifecycle: { type: 'cnb', data: { buildpacks: ['http:https://example.com'], credentials: { registry: { user: 'password' } } } } |
| lifecycle_data = response_body['lifecycle']['data'] | ||
|
|
||
| expect(response).to have_http_status :created | ||
| expect(lifecycle_data).to eq({ 'buildpacks' => ['http:https://buildpack.com'], 'stack' => 'default-stack-name', 'credentials' => '***' }) |
There was a problem hiding this comment.
Suggested change
| expect(lifecycle_data).to eq({ 'buildpacks' => ['http:https://buildpack.com'], 'stack' => 'default-stack-name', 'credentials' => '***' }) | |
| expect(lifecycle_data).to eq({ 'buildpacks' => ['http:https://example.com'], 'stack' => 'default-stack-name', 'credentials' => '***' }) |
| @@ -1,5 +1,5 @@ | |||
| require 'spec_helper' | |||
There was a problem hiding this comment.
Shouldn't that file be located at spec/unit/lib/cloud_controller/diego/buildpack/lifecycle_data_spec.rb
There was a problem hiding this comment.
good point, the file has been moved
johha
requested changes
Jun 26, 2024
johha
approved these changes
Jun 27, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
Building on #3778, this PR introduces the ability to use the
cnblifecycle with password protected Cloud Native Buildpacks.An explanation of the use cases your change solves
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests