Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark weighted route destinations as deprecated in docs #3779

Merged
merged 1 commit into from
May 3, 2024

Conversation

tcdowney
Copy link
Member

@tcdowney tcdowney commented May 2, 2024

  • A short explanation of the proposed change:

Updates V3 API docs to clarify that weighted route destinations are no longer supported. The Istio Service Mesh routing layer is required for weighted routes to function, but development on it was discontinued in early 2020. See: https://github.com/cloudfoundry-attic/istio-release

  • An explanation of the use cases your change solves

Makes it clear to API consumers that setting weights on route destinations will not have any effect on routing traffic.

  • Links to any other associated PRs
  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

- The Istio Service Mesh routing layer is required for weighted routes
  to function, but development on it was discontinued in early 2020.
  See: https://github.com/cloudfoundry-attic/istio-release
- As a consequence, weighted route destinations are no longer supported.
- See this issue for more information about the removal of
Istio support from Cloud Controller: #2942
@tcdowney tcdowney requested review from Gerg and sethboyles May 2, 2024 21:46
@moleske moleske merged commit bfae47a into main May 3, 2024
2 checks passed
@moleske moleske deleted the update-v3-api-docs-route-weight branch May 3, 2024 04:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants