Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: [C3] ensure that is true on the pnpm ubuntu C3 e2e test run #6456

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

petebacondarwin
Copy link
Contributor

Our release job ("Handle Changesets") always fails on its last step because there are no C3 diffs artifacts to download.
We only want to create those artifacts in a single e2e test run (the pnpm + ubuntu one) so there is a check in that e2e CI job.
Unfortunately the check was wrong, since we converted the pm matrix value from a string (e.g. "pnpm") to an object (e.g. {name: "pnpm", version: "9.1.3"}).

@petebacondarwin petebacondarwin requested a review from a team as a code owner August 9, 2024 13:22
Copy link

changeset-bot bot commented Aug 9, 2024

⚠️ No Changeset found

Latest commit: 495e3cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 9, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10319998144/npm-package-wrangler-6456

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6456/npm-package-wrangler-6456

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10319998144/npm-package-wrangler-6456 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10319998144/npm-package-create-cloudflare-6456 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10319998144/npm-package-cloudflare-kv-asset-handler-6456
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10319998144/npm-package-miniflare-6456
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10319998144/npm-package-cloudflare-pages-shared-6456
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10319998144/npm-package-cloudflare-vitest-pool-workers-6456
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10319998144/npm-package-cloudflare-workers-shared-6456

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240806.0
workerd 1.20240806.0 1.20240806.0
workerd --version 1.20240806.0 2024-08-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin petebacondarwin merged commit 30e945b into main Aug 9, 2024
18 checks passed
@petebacondarwin petebacondarwin deleted the fix-c3-diff-uploads branch August 9, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants