-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(miniflare): Implement KV/Assets plugin and Workers Assets simulator #6403
Conversation
🦋 Changeset detectedLatest commit: 9c0098e The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10401949551/npm-package-wrangler-6403 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6403/npm-package-wrangler-6403 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10401949551/npm-package-wrangler-6403 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10401949551/npm-package-create-cloudflare-6403 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10401949551/npm-package-cloudflare-kv-asset-handler-6403 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10401949551/npm-package-miniflare-6403 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10401949551/npm-package-cloudflare-pages-shared-6403 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10401949551/npm-package-cloudflare-vitest-pool-workers-6403 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10401949551/npm-package-cloudflare-workers-editor-shared-6403 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10401949551/npm-package-cloudflare-workers-shared-6403 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
04d2d43
to
909d11f
Compare
909d11f
to
7b670cb
Compare
13c9577
to
28e2453
Compare
28e2453
to
83ce8a3
Compare
83ce8a3
to
68f31f1
Compare
3d31814
to
72bd983
Compare
5510317
to
9af15dc
Compare
9af15dc
to
badc4d9
Compare
@petebacondarwin this is ready to re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this in and iterate next week.
badc4d9
to
f53cf10
Compare
This commit adds a new KV/Assets plugin and an Assets Worker in Miniflare, that are meant to emulate Workers with Assets in local development.
f53cf10
to
9c0098e
Compare
What this PR solves / how to test
This commit extends Miniflare's KV plugin's behaviour to support Workers assets, and therefore enables the emulation of Workers with assets in local development.
Fixes WC-2394
Author has addressed the following