Update hash code usage for capnp change #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(They aren't.)
jasnell
approved these changes
Jun 21, 2024
This may or may not be necessary in conjunction with the KJ hashCode() change: capnproto/capnproto#2086 I couldn't figure out if V8's `GetIdentityHash()` returns uniform hashes vs., say, addresses. It looks like in at least some cases they are uniform, but it's really hard to _find_ all the V8 hash implementations in their code. Some seem to be generated by Torque? If we just wrap these in `kj::hashCode()` then our bases should be covered, at the expense of an extra cycle or three to rehash the values.
kentonv
force-pushed
the
kenton/fix-hashes
branch
from
2944e13
to
1eb2e0b
Compare
To me this doesn't feel like something that belongs in the readme, but I did add a comment to the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.