Implement node.js buffer.isAscii|isUtf8 #2281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
commented
Jun 17, 2024
jasnell
force-pushed
the
jsnell/node-buffer-is-ascii-utf8
branch
from
c72e6ce
to
de35a1d
Compare
dom96
approved these changes
Jun 18, 2024
This change adds two new methods to the node.js Buffer class: isAscii and isUtf8. These methods are used to check if the buffer contains only ASCII or UTF-8 characters, respectively. The implementation of these methods is based on the simdutf library, just like in Node.js itself.
jasnell
force-pushed
the
jsnell/node-buffer-is-ascii-utf8
branch
from
de35a1d
to
c2648e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds two new methods to the node.js Buffer class: isAscii and isUtf8. These methods are used to check if the buffer contains only ASCII or UTF-8 characters, respectively.
The implementation of these methods is based on the simdutf library, just like in Node.js itself. (the dependency will be used for other things too... this is just the first thing)