[CI] Fix miniflare build #2256
Merged
[CI] Fix miniflare build #2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhanau
force-pushed
the
felix/npm-types-fix3
branch
from
99e2c9e
to
c1cc45d
Compare
The issue is a re-edition of #2168, no longer defining the version directly should stop this from reappearing.
fhanau
force-pushed
the
felix/npm-types-fix3
branch
from
c1cc45d
to
648029f
Compare
|
@petebacondarwin @penalosa Was about to ask for ideas on coupling CI better to avoid issues like this in the future, but looks like there's a simple solution 😌. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is a re-edition of #2168, no longer defining the version directly
should stop this from reappearing.