include object name & version in log for r2 hash length mismatch #2250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
reviewed
Jun 10, 2024
src/workerd/api/r2-bucket.c++
Outdated
| @@ -116,39 +116,44 @@ static jsg::Ref<T> parseObjectMetadata(R2HeadResponse::Reader responseReader, | |||
| auto md5 = checksumsBuilder.getMd5(); | |||
| if (md5.size() != 16) { | |||
| KJ_LOG(WARNING, "NOSENTRY MD5 checksum is not 16 bytes long", | |||
| md5.size(), md5.asBytes()); | |||
| md5.size(), md5.asBytes(), | |||
| responseReader.getName(), responseReader.getVersion()); | |||
There was a problem hiding this comment.
I guess if we're expanding the logging here moving it out to a separate utility method here to eliminate the duplication would be useful but I'm hoping this logging can be temporary so likely not worth changing further now :-)
There was a problem hiding this comment.
Haha, that's how a lot of code like this has stuck around in the past 😅 . Pushed a commit wrapping this in a little utility function.
jasnell
approved these changes
Jun 10, 2024
Frederik-Baetens
force-pushed
the
fbaetens/r2_wrong_hash_log_name
branch
from
36ba6b3
to
b05c649
Compare
Frederik-Baetens
force-pushed
the
fbaetens/r2_wrong_hash_log_name
branch
from
b05c649
to
eb55d58
Compare
|
Merged, but let me know if you have any comments around the utility function I added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.