Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename fallback service "raw" param to "rawSpecifier" #2186

Merged
merged 1 commit into from
May 30, 2024

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented May 29, 2024

This was supposed to have been done in the original PR but I accidentally forgot to merge the change in that PR

This was supposed to have been done in the original PR but I
accidentally forgot to merge the change in that PR
Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! thanks! 😄

Copy link
Collaborator

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell
Copy link
Member Author

jasnell commented May 29, 2024

Just pending a review from someone else on the runtime team before this can land... it's ready to go otherwise.

@jasnell jasnell requested review from dom96 and fhanau May 29, 2024 16:52
@jasnell jasnell merged commit 391bbb8 into main May 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants