Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Expose TransformStreamDefaultController as global #2151

Merged
merged 1 commit into from
May 24, 2024

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented May 22, 2024

Fixes: #2149

@jasnell jasnell requested a review from IgorMinar May 22, 2024 16:37
@jasnell jasnell requested review from a team as code owners May 22, 2024 16:37
Copy link
Collaborator

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've manually tested this changed and can confirm that TransformStreamDefaultController is now correctly exposed on globalThis.

@jasnell jasnell requested review from dom96 and fhanau May 22, 2024 18:53
@jasnell jasnell changed the title Expose TransformStreamDefaultController as global Bug Fix: Expose TransformStreamDefaultController as global May 24, 2024
@jasnell jasnell merged commit 0ff3e54 into main May 24, 2024
12 checks passed
@jasnell jasnell deleted the jsnell/export-transformstreamdefaultcontroller-global branch May 24, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 node_compat: globalThis.TransformStreamDefaultController is undefined
3 participants