actor-cache: migrate DO default shutdown exception type from "overloaded" to "disconnected" #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded" to "disconnected" These are the "Durable Object storage is no longer accessible" exceptions that can happen on worker shutdown. It is unknown if these still occur, but it seems likely that they would occur due to a transient reason rather than overload, so we'd like to treat them as retryable.
...to maybe make it easier to deploy.
jasnell
approved these changes
May 21, 2024
justin-mp
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These "Durable Object storage is no longer accessible" exceptions would occur during actor destruction, if no other explicit exception is provided. It is unknown if these still occur, but it seems likely that they would occur due to a transient reason -- like the worker getting evicted -- rather than overload, so we'd like to treat them as retryable.