Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reference to Miniflare#getDurableObjectStorage() #744

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Remove reference to Miniflare#getDurableObjectStorage() #744

merged 1 commit into from
Dec 20, 2023

Conversation

mrbbot
Copy link
Contributor

@mrbbot mrbbot commented Nov 16, 2023

We don't support this in Miniflare 3 yet, so let's remove it from the docs for now.

@mrbbot mrbbot requested a review from a team November 16, 2023 12:18
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 16, 2023

⚠️ No Changeset found

Latest commit: 3b4ff0f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

RamIdeas
RamIdeas approved these changes Dec 20, 2023
View reviewed changes
Copy link

@RamIdeas RamIdeas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were a lot of redundant formatting changes in this diff – was that prettier or did you do it manually? 😅

@mrbbot
Copy link
Contributor Author

mrbbot commented Dec 20, 2023

Prettier 😅

@mrbbot mrbbot merged commit 582fc7e into master Dec 20, 2023
5 of 6 checks passed
@mrbbot mrbbot deleted the bcoll/remove-get-durable-object-storage branch December 20, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RamIdeas RamIdeas RamIdeas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrbbot @RamIdeas