Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node 21 compatibility #734

Merged

Conversation

jkeys089
Copy link
Contributor

Resolves #732

Copy link

changeset-bot bot commented Oct 31, 2023

⚠️ No Changeset found

Latest commit: 6130cdb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jkeys089
Copy link
Contributor Author

jkeys089 commented Nov 7, 2023

@mrbbot the failed check actually passed on my fork (see https://github.com/jkeys089/miniflare/actions/runs/6713276121/job/18463634847). I just re-ran it again to be sure nothing else has changed in node latest on windows-latest and it succeeded again. Could you possibly re-run https://github.com/cloudflare/miniflare/actions/runs/6713336179/job/18438370624?

@mrbbot
Copy link
Contributor

mrbbot commented Nov 8, 2023

Re-running... 🙂

@mrbbot mrbbot merged commit 2d9e3e1 into cloudflare:master Nov 8, 2023
6 checks passed
@mrbbot
Copy link
Contributor

mrbbot commented Jan 17, 2024

Hey! 👋 Apologies for the delay, but this has now been released as part of [email protected]. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node 21 vitest-environment-miniflare compatibility
2 participants