Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation banner to docs #603

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Add deprecation banner to docs #603

merged 1 commit into from
Jun 13, 2023

Conversation

mrbbot
Copy link
Contributor

@mrbbot mrbbot commented Jun 13, 2023

This PR adds a banner to the top of the Miniflare 2 docs (https://miniflare.dev), warning users that Miniflare 2 is no longer supported aside from security updates.
image

This required patching the cloudflare-docs-engine. The old cloudflare-docs-engine has quite a complicated setup process, so rather than doing this with patch-package, I've just pushed my patches to a new branch on that repo (cloudflare/cloudflare-docs-engine@master...bcoll/miniflare-2-banner) and updated the commit hash here.

@mrbbot mrbbot requested a review from a team June 13, 2023 10:59
@changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2023

⚠️ No Changeset found

Latest commit: 5d40644

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mrbbot mrbbot merged commit a645609 into master Jun 13, 2023
4 of 6 checks passed
@mrbbot mrbbot deleted the bcoll/docs-warning-banner branch June 13, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants