Add support for live reload #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JacobMGEvans
approved these changes
Nov 9, 2022
penalosa
reviewed
Nov 9, 2022
penalosa
requested changes
Nov 9, 2022
mrbbot
force-pushed
the
tre-live-reload
branch
from
98b2858
to
d7fb8cc
Compare
This PR brings over Miniflare 2's live reload feature to Miniflare 3. This automatically reloads pages whenever options are changed or the server is restarted. Note that instead of terminating WebSocket's in `workerd`, we terminate them in `Miniflare`. This allows us to instantly send messages to all connected clients once options are applied, reducing the reload latency. ⚡
mrbbot
force-pushed
the
tre-live-reload
branch
from
d7fb8cc
to
8c5c4e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings over Miniflare 2's live reload feature to Miniflare 3. This automatically reloads pages whenever options are changed or the server is restarted.
Note that instead of terminating WebSocket's in
workerd, we terminate them inMiniflare. This allows us to instantly send messages to all connected clients once options are applied, reducing the reload latency. ⚡