Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undici Dispatcher's request.headersList.entries changed into an object #607

Closed
hansottowirtz opened this issue Jun 14, 2023 · 0 comments · Fixed by #742
Closed

Undici Dispatcher's request.headersList.entries changed into an object #607

hansottowirtz opened this issue Jun 14, 2023 · 0 comments · Fixed by #742

Comments

@hansottowirtz
Copy link
Contributor

hansottowirtz commented Jun 14, 2023

This comment kind of explains itself:

// Note: I'm fully expecting this to break in future undici versions
// and need to be updated, but that's why we pin our undici version and
// have tests
assert(Array.isArray(headers));

This breaks in the latest Undici version.

It's now a Record<string, string>: https://github.com/nodejs/undici/blob/main/lib/fetch/headers.js#L176-L186

mrbbot added a commit that referenced this issue Nov 13, 2023
Addresses low severity `npm audit` warning:
GHSA-wqq4-5wpv-mx2g

Fixes #607
Fixes #738
mrbbot added a commit that referenced this issue Jan 4, 2024
Addresses low severity `npm audit` warning:
GHSA-wqq4-5wpv-mx2g

Fixes #607
Fixes #738
mrbbot added a commit that referenced this issue Jan 4, 2024
Addresses low severity `npm audit` warning:
GHSA-wqq4-5wpv-mx2g

Fixes #607
Fixes #738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant