cmd/compile: add intrinsic for MulUintptr on arm64

This CL adds intrinsic for runtime/internal/math.MulUintptr on arm64 Benchmark master ThisCL(ns/op) delta MulUintptr/small 0.95ns 0.79ns -16% MulUintptr/large 1.31ns 0.95ns -27.6% Change-Id: Ic7b453ad502826beffe93ce5531b8ba752312a1b Reviewed-on: https://go-review.googlesource.com/c/go/+/419556 Reviewed-by: Keith Randall <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Keith Randall <[email protected]> Run-TryBot: Eric Fang <[email protected]> Auto-Submit: Keith Randall <[email protected]> Reviewed-by: Joedian Reid <[email protected]>
cloudflare · Aug 19, 2022 · d654117 · d654117
1 parent f15761b
commit d654117
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 1 deletion.
diff --git a/src/cmd/compile/internal/ssa/gen/ARM64.rules b/src/cmd/compile/internal/ssa/gen/ARM64.rules
@@ -2977,3 +2977,8 @@
  => (Move [sz] dst src mem)
 
 ((REV|REVW) ((REV|REVW) p)) => p
+
+// runtime/internal/math.MulUintptr intrinsics
+
+(Select0 (Mul64uover x y)) => (MUL x y)
+(Select1 (Mul64uover x y)) => (NotEqual (CMPconst (UMULH <typ.UInt64> x y) [0]))
diff --git a/src/cmd/compile/internal/ssa/rewriteARM64.go b/src/cmd/compile/internal/ssa/rewriteARM64.go
diff --git a/src/cmd/compile/internal/ssagen/ssa.go b/src/cmd/compile/internal/ssagen/ssa.go
@@ -3908,7 +3908,7 @@ func InitTables() {
  }
  return s.newValue2(ssa.OpMul64uover, types.NewTuple(types.Types[types.TUINT], types.Types[types.TUINT]), args[0], args[1])
  },
- sys.AMD64, sys.I386, sys.Loong64, sys.MIPS64, sys.RISCV64)
+ sys.AMD64, sys.I386, sys.Loong64, sys.MIPS64, sys.RISCV64, sys.ARM64)
  alias("runtime", "mulUintptr", "runtime/internal/math", "MulUintptr", all...)
  add("runtime", "KeepAlive",
  func(s *state, n *ir.CallExpr, args []*ssa.Value) *ssa.Value {