cmd/compile: remove period from "not allowed in runtime" errors

We don't punctuate compiler diagnostics. Change-Id: I19e1f30fbf04f0d1bfe6648fae26beaf3a06ee92 Reviewed-on: https://go-review.googlesource.com/c/go/+/201077 Reviewed-by: Brad Fitzpatrick <[email protected]>
cloudflare · Oct 14, 2019 · b649bdc · b649bdc
1 parent 06b12e6
commit b649bdc
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/src/cmd/compile/internal/gc/closure.go b/src/cmd/compile/internal/gc/closure.go
@@ -345,7 +345,7 @@ func closuredebugruntimecheck(clo *Node) {
  }
  }
  if compiling_runtime && clo.Esc == EscHeap {
- yyerrorl(clo.Pos, "heap-allocated closure, not allowed in runtime.")
+ yyerrorl(clo.Pos, "heap-allocated closure, not allowed in runtime")
  }
 }
 

diff --git a/src/cmd/compile/internal/gc/esc.go b/src/cmd/compile/internal/gc/esc.go
@@ -251,7 +251,7 @@ func moveToHeap(n *Node) {
  Dump("MOVE", n)
  }
  if compiling_runtime {
- yyerror("%v escapes to heap, not allowed in runtime.", n)
+ yyerror("%v escapes to heap, not allowed in runtime", n)
  }
  if n.Class() == PAUTOHEAP {
  Dump("n", n)

diff --git a/src/cmd/compile/internal/gc/walk.go b/src/cmd/compile/internal/gc/walk.go
@@ -195,7 +195,7 @@ func walkstmt(n *Node) *Node {
  v := n.Left
  if v.Class() == PAUTOHEAP {
  if compiling_runtime {
- yyerror("%v escapes to heap, not allowed in runtime.", v)
+ yyerror("%v escapes to heap, not allowed in runtime", v)
  }
  if prealloc[v] == nil {
  prealloc[v] = callnew(v.Type)

diff --git a/test/fixedbugs/issue14999.go b/test/fixedbugs/issue14999.go
@@ -7,11 +7,11 @@
 package p
 
 func f(x int) func(int) int {
- return func(y int) int { return x + y } // ERROR "heap-allocated closure, not allowed in runtime."
+ return func(y int) int { return x + y } // ERROR "heap-allocated closure, not allowed in runtime"
 }
 
-func g(x int) func(int) int { // ERROR "x escapes to heap, not allowed in runtime."
- return func(y int) int { // ERROR "heap-allocated closure, not allowed in runtime."
+func g(x int) func(int) int { // ERROR "x escapes to heap, not allowed in runtime"
+ return func(y int) int { // ERROR "heap-allocated closure, not allowed in runtime"
  x += y
  return x + y
  }