cmd/compile: fix late call expansion for SSA-able aggregate results a…

…nd arguments

This change incorporates the decision that it should be possible to
run call expansion relatively late in the optimization chain, so that
(1) calls themselves can be exposed to useful optimizations
(2) the effect of selectors on aggregates is seen at the rewrite,
    so that assignment of parts into registers is less complicated
    (at least I hope it works that way).

That means that selectors feeding into SelectN need to be processed,
and Make* feeding into call parameters need to be processed.

This does however require that call expansion run before decompose
builtins.

This doesn't yet handle rewrites of strings, slices, interfaces,
and complex numbers.

Passes run.bash and race.bash

Change-Id: I71ff23d3c491043beb30e926949970c4f63ef1a4
Reviewed-on: https://go-review.googlesource.com/c/go/+/245133
Trust: David Chase <[email protected]>
Run-TryBot: David Chase <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Cherry Zhang <[email protected]>

src/cmd/compile/internal/gc/ssa.go

@@ -10,7 +10,6 @@ import (
  "html"
  "os"
  "sort"
- "strings"
 
  "bufio"
  "bytes"
@@ -2560,19 +2559,19 @@ func (s *state) expr(n *Node) *ssa.Value {
  if s.prevCall == nil || s.prevCall.Op != ssa.OpStaticLECall {
  // Do the old thing
  addr := s.constOffPtrSP(types.NewPtr(n.Type), n.Xoffset)
- return s.load(n.Type, addr)
+ return s.rawLoad(n.Type, addr)
  }
  which := s.prevCall.Aux.(*ssa.AuxCall).ResultForOffset(n.Xoffset)
  if which == -1 {
  // Do the old thing // TODO: Panic instead.
  addr := s.constOffPtrSP(types.NewPtr(n.Type), n.Xoffset)
- return s.load(n.Type, addr)
+ return s.rawLoad(n.Type, addr)
  }
  if canSSAType(n.Type) {
  return s.newValue1I(ssa.OpSelectN, n.Type, which, s.prevCall)
  } else {
  addr := s.newValue1I(ssa.OpSelectNAddr, types.NewPtr(n.Type), which, s.prevCall)
- return s.load(n.Type, addr)
+ return s.rawLoad(n.Type, addr)
  }
 
  case ODEREF:
@@ -4377,7 +4376,7 @@ func (s *state) call(n *Node, k callKind, returnResultAddr bool) *ssa.Value {
  case OCALLFUNC:
  if k == callNormal && fn.Op == ONAME && fn.Class() == PFUNC {
  sym = fn.Sym
- if !returnResultAddr && strings.Contains(sym.Name, "testLateExpansion") {
+ if !returnResultAddr && ssa.LateCallExpansionEnabledWithin(s.f) {
  testLateExpansion = true
  }
  break
@@ -4394,7 +4393,7 @@ func (s *state) call(n *Node, k callKind, returnResultAddr bool) *ssa.Value {
  }
  if k == callNormal {
  sym = fn.Sym
- if !returnResultAddr && strings.Contains(sym.Name, "testLateExpansion") {
+ if !returnResultAddr && ssa.LateCallExpansionEnabledWithin(s.f) {
  testLateExpansion = true
  }
  break

src/cmd/compile/internal/ssa/compile.go

@@ -431,9 +431,9 @@ var passes = [...]pass{
  {name: "nilcheckelim", fn: nilcheckelim},
  {name: "prove", fn: prove},
  {name: "early fuse", fn: fuseEarly},
+ {name: "expand calls", fn: expandCalls, required: true},
  {name: "decompose builtin", fn: decomposeBuiltIn, required: true},
  {name: "softfloat", fn: softfloat, required: true},
- {name: "expand calls", fn:expandCalls, required: true},
  {name: "late opt", fn: opt, required: true}, // TODO: split required rules and optimizing rules
  {name: "dead auto elim", fn: elimDeadAutosGeneric},
  {name: "generic deadcode", fn: deadcode, required: true}, // remove dead stores, which otherwise mess up store chain

src/cmd/compile/internal/ssa/config.go

@@ -196,6 +196,14 @@ const (
  ClassParamOut // return value
 )
 
+const go116lateCallExpansion = true
+
+// LateCallExpansionEnabledWithin returns true if late call expansion should be tested
+// within compilation of a function/method triggered by GOSSAHASH (defaults to "yes").
+func LateCallExpansionEnabledWithin(f *Func) bool {
+ return go116lateCallExpansion && f.DebugTest // Currently set up for GOSSAHASH bug searches
+}
+
 // NewConfig returns a new configuration object for the given architecture.
 func NewConfig(arch string, types Types, ctxt *obj.Link, optimize bool) *Config {
  c := &Config{arch: arch, Types: types}