cmd/compile: fix blank label code

When checkEnabled is forced true, the 52278 test fails. Be a bit more careful about processing blank labels. Update #52278 Change-Id: I48aa89e2c9e3715d8efe599bc4363b5b5879d8a2 Reviewed-on: https://go-review.googlesource.com/c/go/+/419318 Run-TryBot: Keith Randall <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Reviewed-by: David Chase <[email protected]>
cloudflare · Jul 25, 2022 · 24dc27a · 24dc27a
1 parent 9fcc8b2
commit 24dc27a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/cmd/compile/internal/ssagen/ssa.go b/src/cmd/compile/internal/ssagen/ssa.go
@@ -1496,6 +1496,10 @@ func (s *state) stmt(n ir.Node) {
  case ir.OLABEL:
  n := n.(*ir.LabelStmt)
  sym := n.Label
+ if sym.IsBlank() {
+ // Nothing to do because the label isn't targetable. See issue 52278.
+ break
+ }
  lab := s.label(sym)
 
  // The label might already have a target block via a goto.

diff --git a/test/fixedbugs/issue52278.go b/test/fixedbugs/issue52278.go
@@ -1,4 +1,4 @@
-// compile
+// compile -d=ssa/check/on
 
 // Copyright 2022 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style