-
Notifications
You must be signed in to change notification settings - Fork 44
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
cmd/compile: more error position tests for the typechecker
This change adds line position tests for several yyerror calls in the typechecker that are currently not tested in any way. Untested yyerror calls were found by replacing them with yerrorl(src.NoXPos, ...) (thus destroying position information in the error), and then running the test suite. No failures means no test coverage for the relevant yyerror call. For #19683 Change-Id: Iedb3d2f02141b332e9bfa76dbf5ae930ad2fddc3 Reviewed-on: https://go-review.googlesource.com/41477 Run-TryBot: Alberto Donizetti <[email protected]> Reviewed-by: Josh Bleecher Snyder <[email protected]> Reviewed-by: Matthew Dempsky <[email protected]>
- Loading branch information
Showing
12 changed files
with
134 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
// errorcheck | ||
|
||
// Copyright 2017 The Go Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style | ||
// license that can be found in the LICENSE file. | ||
|
||
// Verify that append arguments requirements are enforced by the | ||
// compiler. | ||
|
||
package main | ||
|
||
func main() { | ||
|
||
s := make([]int, 8) | ||
|
||
_ = append() // ERROR "missing arguments to append" | ||
_ = append(s...) // ERROR "cannot use ... on first argument" | ||
_ = append(s, 2, s...) // ERROR "too many arguments to append" | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
// errorcheck | ||
|
||
// Copyright 2017 The Go Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style | ||
// license that can be found in the LICENSE file. | ||
|
||
// Verify that copy arguments requirements are enforced by the | ||
// compiler. | ||
|
||
package main | ||
|
||
func main() { | ||
|
||
si := make([]int, 8) | ||
sf := make([]float64, 8) | ||
|
||
_ = copy() // ERROR "missing arguments" | ||
_ = copy(1, 2, 3) // ERROR "too many arguments" | ||
|
||
_ = copy(si, "hi") // ERROR "have different element types.*int.*string" | ||
_ = copy(si, sf) // ERROR "have different element types.*int.*float64" | ||
|
||
_ = copy(1, 2) // ERROR "must be slices; have int, int" | ||
_ = copy(1, si) // ERROR "first argument to copy should be" | ||
_ = copy(si, 2) // ERROR "second argument to copy should be" | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
// errorcheck | ||
|
||
// Copyright 2017 The Go Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style | ||
// license that can be found in the LICENSE file. | ||
|
||
// Verify that make and new arguments requirements are enforced by the | ||
// compiler. | ||
|
||
package main | ||
|
||
func main() { | ||
_ = make() // ERROR "missing argument" | ||
_ = make(int) // ERROR "cannot make type" | ||
_ = make([]int) // ERROR "missing len argument" | ||
|
||
_ = new() // ERROR "missing argument" | ||
_ = new(int, 2) // ERROR "too many arguments" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
// errorcheck | ||
|
||
// Copyright 2017 The Go Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style | ||
// license that can be found in the LICENSE file. | ||
|
||
// Verify that recover arguments requirements are enforced by the | ||
// compiler. | ||
|
||
package main | ||
|
||
func main() { | ||
_ = recover() // OK | ||
_ = recover(1) // ERROR "too many arguments" | ||
_ = recover(1, 2) // ERROR "too many arguments" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters