Fail if module does not compile #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bobrik
added a commit
to bobrik/ebpf_exporter
that referenced
this pull request
Feb 27, 2024
Attaching uprobes if fickle and requires function attributes to work properly. Let's switch to usdt, which have no such downside. The price we pay is a dependecy on `systemtap-sdt-dev`, which is manageable. We get nicer attachment code with `BPF_USDT` as a bonus. The usdt probes can be inspected: ``` ivan@vm:~/projects/ebpf_exporter$ sudo tplist-bpfcc -vv -l tracing/demos/cfs-throttling/demo ebpf_exporter:cfs_set_parent_span [sema 0x0] location #1 tracing/demos/cfs-throttling/demo 0x92f3cc argument #1 8 unsigned bytes @ regs[10] argument cloudflare#2 8 unsigned bytes @ regs[9] argument cloudflare#3 8 unsigned bytes @ regs[8] location cloudflare#2 tracing/demos/cfs-throttling/demo 0x92f408 argument #1 8 unsigned bytes @ regs[13] argument cloudflare#2 8 unsigned bytes @ regs[11] argument cloudflare#3 8 unsigned bytes @ regs[8] ebpf_exporter:cfs_clear_parent_span [sema 0x0] location #1 tracing/demos/cfs-throttling/demo 0x92f3d8 location cloudflare#2 tracing/demos/cfs-throttling/demo 0x92f3e0 ```
bobrik
added a commit
to bobrik/ebpf_exporter
that referenced
this pull request
Feb 27, 2024
Attaching uprobes if fickle and requires function attributes to work properly. Let's switch to usdt, which have no such downside. The price we pay is a dependecy on `systemtap-sdt-dev`, which is manageable. We get nicer attachment code with `BPF_USDT` as a bonus. The usdt probes can be inspected: ``` ivan@vm:~/projects/ebpf_exporter$ sudo tplist-bpfcc -vv -l tracing/demos/cfs-throttling/demo ebpf_exporter:cfs_set_parent_span [sema 0x0] location #1 tracing/demos/cfs-throttling/demo 0x92f3cc argument #1 8 unsigned bytes @ regs[10] argument cloudflare#2 8 unsigned bytes @ regs[9] argument cloudflare#3 8 unsigned bytes @ regs[8] location cloudflare#2 tracing/demos/cfs-throttling/demo 0x92f408 argument #1 8 unsigned bytes @ regs[13] argument cloudflare#2 8 unsigned bytes @ regs[11] argument cloudflare#3 8 unsigned bytes @ regs[8] ebpf_exporter:cfs_clear_parent_span [sema 0x0] location #1 tracing/demos/cfs-throttling/demo 0x92f3d8 location cloudflare#2 tracing/demos/cfs-throttling/demo 0x92f3e0 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.