Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing deps inconsistencies and clippy errors #282

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

sabify
Copy link
Contributor

@sabify sabify commented Jul 3, 2022

This PR will resolve cargo's install and clippy errors due to deps inconsistencies.

@Noah-Kennedy
Copy link
Collaborator

@jeff-hiner not sure how I feel about pre-release crates for cryptography, would like your comment on this.

@jeff-hiner
Copy link
Contributor

jeff-hiner commented Jul 5, 2022

We've been awaiting official releases of RustCrypto crates for several months now. The transitive deps on old rand_core are awful.

I do agree that it's preferable to not pin to .pre candidates, but in this case as a compromise I think we could reasonably cut a 0.5.0-pre release on our own side with these changes and pend a full release on RustCrypto stuff being updated.

Also we should try to apply some pressure to the RustCrypto maintainer to cut a release. The stated reason for not doing so earlier was because of rustc version requirements, but the version in question has been stable for a while, and that's exactly what minor rev bumps are for.

@sabify
Copy link
Contributor Author

sabify commented Jul 6, 2022

Any plan to merge this PR?

cargo install doesn't work at the current stage.

@Noah-Kennedy
Copy link
Collaborator

@jeff-hiner I'm going to defer to you here.

@jeff-hiner jeff-hiner merged commit a97c6f5 into cloudflare:master Jul 6, 2022
arvydasv pushed a commit to NordSecurity/boringtun that referenced this pull request Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants