produce stacktrace buffer even when cider-popup-stacktraces is nil #603
Conversation
|
Have a look at my final remarks regarding #602. I think we should combine all stacktrace variables into one. The current situation is more complex and more confusing than it needs to be. |
|
I have just implemented the proposed popup behavior. |
| "Control the popup behavior of cider stacktraces. | ||
| The following values are posible t or 'always, 'except-in-repl, | ||
| 'only-in-repl. Any other value, including nil, will cause the stacktrace | ||
| not to be automatically poped. In the later case, the `cider-error-buffer' |
|
@Vitoshka Nice! |
| ```el | ||
| (setq cider-popup-stacktraces nil) | ||
| (setq cider-popup-stacktraces nil) |
There was a problem hiding this comment.
I think we should rename this to cider-show-stacktrace-buffer. (or something like that) I find the entire popup terminology a bit confusing.
|
Address my remarks and squash all commits into one. Your commit message should be with the format |
|
|
||
| Never popup. |
There was a problem hiding this comment.
Perhaps those should be sub-bullets.
|
@Vitoshka Ping :-) |
|
Sorry, I have had a very busy week. Will address all of your comments in the following days. |
|
Hi. I have just commited a new patch.Should be fine this time. |
produce stacktrace buffer even when cider-popup-stacktraces is nil
Fix the issues with stacktraces in #602. I have renamed the cider-popup-on-error because it wasn't really doing any popup and the name was conflicting with
cider-popup-stacktraces.