Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add force-out support. #2800

Merged
merged 7 commits into from
Feb 27, 2020
Merged

Conversation

FiV0
Copy link
Contributor

@FiV0 FiV0 commented Feb 16, 2020

Adding the option to force out of a debugging operation. Also skips
instrumented functions lower in the call stack. Already implemented
at cider-nrepl level.

Replace this placeholder text with a summary of the changes in your PR.
The more detailed you are, the better.


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (make test)
  • All code passes the linter (make lint) which is based on elisp-lint and includes
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality)

Thanks!

If you're just starting out to hack on CIDER you might find this section of its
manual
extremely useful.

Adding the option to force out of a debugging operation. Also skips
instrumented functions lower in the call stack. Already implemented
at cider-nrepl level.
@FiV0
Copy link
Contributor Author

FiV0 commented Feb 16, 2020

@bbatsov Are the tests failure due to me or due to me or jorgenschaefer/emacs-buttercup#122?

cider-debug.el Outdated
@@ -202,6 +202,7 @@ Can be toggled at any time with `\\[cider-debug-toggle-locals]'."
(?n "next" "next")
(?i "in" "in")
(?o "out" "out")
(?O "out" nil)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is what people see in the menu, I guess we should use different wording here - otherwise it's not clear how it differs from the standard "out".

@bbatsov
Copy link
Member

bbatsov commented Feb 21, 2020

I think we also list the debugger commands in its manual with some extra explanations.

@FiV0
Copy link
Contributor Author

FiV0 commented Feb 24, 2020

@bbatsov What do you mean? The big O command is already in the docs.
https://docs.cider.mx/cider/debugging/debugger.html#_keys

@bbatsov bbatsov merged commit 96a4915 into clojure-emacs:master Feb 27, 2020
@bbatsov
Copy link
Member

bbatsov commented Feb 27, 2020

My bad. I didn't notice this. Thanks!

@FiV0 FiV0 deleted the fix-debugger-force-out branch February 27, 2020 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants