Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cider-inspector-def-current-val to cider-inspector #2729

Merged

Conversation

jpmonettas
Copy link
Contributor

Add cider-inspector-def-current-val command to cider inspector so you can define a var with the inspector current value.
Also binds d in the inspector mode map to this command and adds "Define var" to the inspector menu.

Depends on clojure-emacs/cider-nrepl#653


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (make test)
  • All code passes the linter (make lint) which is based on elisp-lint and includes
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality)

@jpmonettas jpmonettas changed the title Add cider-inspect-def-current-val to cider-inspector Add cider-inspector-def-current-val to cider-inspector Oct 12, 2019
@jpmonettas jpmonettas force-pushed the feature/inspector-def-var-current-val branch from 0bb83fe to f7e6941 Compare October 12, 2019 14:30
@jpmonettas jpmonettas force-pushed the feature/inspector-def-var-current-val branch from f7e6941 to 661fd1b Compare October 13, 2019 12:13
@bbatsov bbatsov merged commit ee2d014 into clojure-emacs:master Oct 16, 2019
@bbatsov
Copy link
Member

bbatsov commented Oct 16, 2019

Nicely done! Thanks! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants