-
-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cider-auto-test-mode #1636
cider-auto-test-mode #1636
Conversation
5cf86b8
to
0fe70e0
Compare
Only runs tests corresponding to the loaded file's namespace and does | ||
nothing if no tests are defined or if the file failed to load." | ||
nil nil nil | ||
:global t |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whi is this global?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know. Why would it be local? :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought people would be supposed to enable it using cider-mode-hook
, but if you think this is a better idea - it's fine by me. Just mention the mode somewhere in the manual.
Looks good!
Yeah, I think this should be a defcustom. Btw, the final commit seems unrelated to the PR (and could use a changelog entry). |
;;; Auto-test mode | ||
(defun cider--test-silently () | ||
"Like `cider-test-run-tests', but with less feedback. | ||
Only notify the user if there actually were any tests to run and only after |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm kind of confused about this description - shouldn't this say you'll see the results only if something failed? I might be missing something, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it displays a message if the tests were successful. Otherwise you wouldn't know if the tests are finished or if they're hanging.
The point here is just to not bother the user if there are no tests to run.
|
One more thing - mention this in the manual. |
How do I do that? :-) |
Just edit the files under /doc. The manual will be updated automatically. On Wednesday, 30 March 2016, Artur Malabarba [email protected]
Best Regards, |
Guess you can squash the final 3 commits together and we're good to go. |
It also seems you'll have to rebase on top of the current |
All done. 👍 |
Hehe - this was fast! :-) |
I just discovered |
:-) |
Now I just need to add a |
Is that a joke? :-) |
Lol, sorry now, it was half a question. :) When I do |
Sorry, I think I sounded a bit rude. :-) |
Ahah no probs, I sounded a bit silly in asking indeed, thanks a lot for the hint! |
A minor mode that runs tests after every successful load-file op.
I've been using this a lot lately, and I'm quite happy with it now.
It might make sense to also let the user run tests after every eval op (instead of just load-file). But I actually like that I can play around small code snippets with
C-x C-e
andC-M-x
without accidentally reruning all tests, so I'm leaving this as is for now.