[Fix #1222] Add option to apply a single face to the results overlay #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New variable, cider-ovelays-use-font-lock controls whether results overlay should be font-locked or just use a single face
| :group 'cider | ||
| :package-version "0.9.1") | ||
|
|
||
| (defcustom cider-ovelays-use-font-lock t |
There was a problem hiding this comment.
I think the default should be nil.
There was a problem hiding this comment.
This should also be mentioned in the README (in the common config section).
There was a problem hiding this comment.
I think the default should be nil.
If overlays will be ON, then yes this should be nil.
If overlays will be OFF by default, then I think we can leave this as t (since people will have to explicitly enable overlays, they won't be surprised by it).
I just don't which of the two we want yet.
There was a problem hiding this comment.
The overlays generated only positive feedback for far, so I think we'll leave them on by default.
|
Readme added |
bbatsov
added a commit
that referenced
this pull request
Aug 7, 2015
[Fix #1222] Add option to apply a single face to the results overlay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New variable, cider-ovelays-use-font-lock controls whether results overlay should be font-locked or just use a single face