Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tide Module Example Jupyter Notebook #105

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

socoyjonathan
Copy link

Let me know if apps/geoclaw is the desired location for tide module!

@rjleveque
Copy link
Member

apps/notebooks/geoclaw seems like a good place for this, but I think the same notebook is also in clawpack/tidal-examples#3? Maybe having this basic example both places makes sense, but might be harder to maintain.

I noted in that tidal-examples PR that two different versions of tide.py are used, and in this PR the local tide.py does not exist, so the first import statement fails and should presumably be replaced by
from clawpack.geoclaw import tide

@mandli
Copy link
Member

mandli commented Mar 1, 2022

We should figure out which makes more sense, having both is not a good idea. I had suggested to move the tide.py to GeoClaw itself rather than having it in the apps repository. We probably should just close the original PR in favor of the one that will use the module in GeoClaw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants