Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T/1945: Bumped style-loader to v1.0.0. Aligned configurations and documentation to the new loader API #1949

Merged
merged 9 commits into from
Aug 14, 2019

Conversation

@Reinmar
Copy link
Member

Reinmar commented Aug 12, 2019

I checked that there are far more dependencies that we can upgrade in builds now:

     "postcss-loader": "^3.0.0",
-    "raw-loader": "^1.0.0",
-    "style-loader": "^0.23.0",
-    "uglifyjs-webpack-plugin": "^1.2.7",
-    "webpack": "^4.15.0",
-    "webpack-cli": "^3.0.8"
+    "raw-loader": "^3.1.0",
+    "style-loader": "^1.0.0",
+    "uglifyjs-webpack-plugin": "^2.2.0",
+    "webpack": "^4.39.1",
+    "webpack-cli": "^3.3.6"
   },

I'd upgrade all at once. Also, as long as we don't force you to make them, they are not breaking. E.g. you only need to change your webpack config if you bumped style-loader in your package.json and this is your call. So, if this is the same situation with all the other pkgs, then we can safely do it even now.

So todo:

  1. update other build-step deps (because there's more packages than that that we'll need to upgrade),
  2. make a decision whether this is a safe change that we can do right now.

Copy link
Member

@Reinmar Reinmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented.

@oleq
Copy link
Member Author

oleq commented Aug 13, 2019

I bumped other deps up.

The thing with the uglify plugin is that we cannot go to 2.0 because it's not es6 compatible. We'd have to use terser.

Switch back to uglify-js (uglify-es is abandoned, if you need uglify ES6 code please use terser-webpack-plugin).

Other than that, things look like they're working (raw–loader in particular).

@Reinmar Reinmar merged commit bef7fd0 into master Aug 14, 2019
@Reinmar Reinmar deleted the t/1945 branch August 14, 2019 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility with [email protected]
3 participants