Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Table properties UI] RTL support #6107

Closed
oleq opened this issue Jan 22, 2020 · 2 comments · Fixed by ckeditor/ckeditor5-theme-lark#269 or ckeditor/ckeditor5-table#259
Closed

[Table properties UI] RTL support #6107

oleq opened this issue Jan 22, 2020 · 2 comments · Fixed by ckeditor/ckeditor5-theme-lark#269 or ckeditor/ckeditor5-table#259
Assignees
@panr
Labels
domain:rtl This issue reports a problem with support for right-to-left languages. package:table type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 30 (v18...

Comments

@oleq
Copy link
Member

oleq commented Jan 22, 2020

📝 Provide a description of the improvement

A follow-up of #6049.

ATM there's no RTL support in the table (cell) properties UI but there should be (e.g. different order of alignment buttons).

If you'd like to see this improvement implemented, add a 👍 reaction to this post.
@oleq oleq added type:improvement This issue reports a possible enhancement of an existing feature. package:table domain:rtl This issue reports a problem with support for right-to-left languages. labels Jan 22, 2020
@oleq oleq mentioned this issue Jan 22, 2020
Merged
@oleq oleq added this to the next milestone Jan 23, 2020
@oleq
Copy link
Member Author

oleq commented Feb 20, 2020

This is what it looks like:

image

image

  • Margins and paddings are broken.
  • Color picker dropdown displays on the wrong side.
  • Color picker border radiuses are broken because the palette button is on the other side.
  • Alignment icons are in the wrong order,
  • Are the save and cancel icons on the right side of the text?

@Reinmar Reinmar modified the milestones: next, iteration 30 Feb 21, 2020
@panr panr self-assigned this Feb 28, 2020
This was referenced Mar 2, 2020
Merged
Merged
@panr
Copy link
Contributor

panr commented Mar 2, 2020 •
edited
Loading

I think I fixed all issues except for this:

Are the save and cancel icons on the right side of the text?

I presume that It looks fine as it is...

oleq added a commit to ckeditor/ckeditor5-theme-lark that referenced this issue Mar 9, 2020
@oleq
Merge pull request #269 from ckeditor/i/6107
931351c 
Feature: Brought the right–to–left UI styles to the table and table cell property forms (see ckeditor/ckeditor5#6107).
oleq added a commit to ckeditor/ckeditor5-table that referenced this issue Mar 9, 2020
@oleq
Merge pull request #259 from ckeditor/i/6107
3a92fc4 
Feature: Brought the support for right–to–left languages to the table and table cell property forms. Closes ckeditor/ckeditor5#6107.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@panr panr

Labels
domain:rtl This issue reports a problem with support for right-to-left languages. package:table type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 30 (v18.0.0)
3 participants
@Reinmar @oleq @panr