Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated deps #31

Merged
merged 1 commit into from
May 30, 2019
Merged

Updated deps #31

merged 1 commit into from
May 30, 2019

Conversation

f1ames
Copy link
Contributor

@f1ames f1ames commented May 28, 2019

Updated deps with:

npm outdated
npm update

All tests (unit, e2e) and samples working fine. The main reason of an update was to update indirect tar dependency (to >=2.2.2). This can be checked with npm ls tar.

Closes #28.

@engineering-this engineering-this self-assigned this May 29, 2019
Copy link
Contributor

@engineering-this engineering-this left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

Although there is an another issue which 3.0.0<=tar<4.4.2 used by Karma, but we need to wait for an upstream fix karma-runner/karma#3317.

@engineering-this engineering-this removed their assignment May 30, 2019
@f1ames f1ames mentioned this pull request May 30, 2019
@f1ames
Copy link
Contributor Author

f1ames commented May 30, 2019

I have extracted karma update to separate issue #32.

@f1ames f1ames merged commit 0d93d66 into master May 30, 2019
@f1ames f1ames deleted the t/28 branch May 30, 2019 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dev deps
2 participants