Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JSON-LD catalogs with @graph #159

Merged
merged 2 commits into from
Jul 12, 2019

Conversation

seitenbau-govdata
Copy link
Member

@seitenbau-govdata seitenbau-govdata commented Jul 9, 2019

Adds support for parsing JSON-LD catalogs containing @graph elements.

Links to open issues in rdflib-jsonld relating this problem:

The suggested "solution" is to use rdflib.ConjunctiveGraph() instead of rdflib.Graph().

- Replace rdflib.Graph() with rdflib.ConjunctiveGraph()
- Add test for @graph
- Add example for jsonld with @graph
@metaodi
Copy link
Member

metaodi commented Jul 10, 2019

@seitenbau-govdata is there any downside in using ConjunctiveGraph? So this should work for all our cases? I see that all tests pass, so I guess everything is fine.

@seitenbau-govdata
Copy link
Member Author

seitenbau-govdata commented Jul 10, 2019

@metaodi We have had the same thoughts. Ultimately we don't know it if something special is not working with the ConjunctiveGraph. So, we have to trust the implemented tests that all relevant use cases are covered.

@seitenbau-govdata
Copy link
Member Author

@metaodi What do you think about the pull request? Maybe it's helpful to have another opinion.
@amercader Please let us know your view about the pull request.

@metaodi
Copy link
Member

metaodi commented Jul 11, 2019

I like it and think it's a good solution. I'd say let's risk it and test in all our installations, if something is broken, we can still revert if needed.

@amercader
Copy link
Member

Tests with the alternative JSON-LD syntax seem to pass, so let's merge it

@amercader amercader merged commit 15b73fa into ckan:master Jul 12, 2019
@seitenbau-govdata
Copy link
Member Author

Thanks @metaodi and @amercader !

@seitenbau-govdata seitenbau-govdata deleted the jsonld-catalogs-with-at-graph branch July 15, 2019 10:02
metaodi added a commit that referenced this pull request Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants