fix incompatible function pointer types issue #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
util/events/libuv/Process.c:29:51: error: incompatible function pointer types passing 'Process_OnExitCallback' (aka 'void (*)(long long, int)') to parameter of type 'void (*)(long, int)' [-Wincompatible-function-pointer-types]
return Rffi_spawn(binaryPath, args, i, alloc, callback);
^~~~~~~~
./rust/cjdns_sys/Rffi.h:127:27: note: passing argument to parameter 'cb' here
void (*cb)(long, int));
^
```
Signed-off-by: Rui Chen <[email protected]>
6 tasks
|
cc @cjdelisle |
cjdelisle
reviewed
Jun 26, 2024
| @@ -18,6 +18,11 @@ | |||
| #include "util/Bits.h" | |||
| #include "util/Identity.h" | |||
|
|
|||
| void Process_OnExitCallbackWrapper(long pid, int exitCode) { | |||
| long long pidLongLong = (long long) pid; | |||
There was a problem hiding this comment.
Should be casted to an int64_t because that is not guaranteed to be a long long. On 64 bit machines it is usually a long and I believe on some machines it is possible that long long is uint128_t.
|
Please note that in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While upgrading rust to the latest release, saw the incompatible pointer type issue when building against latest xcode.