Small change to reference object attribute #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
citronneur
added a commit
that referenced
this pull request
Jun 1, 2015
Small change to reference object attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
First off, don't feel that you have to accept this pull request. I just had to make a change in order to run this in a module for my tool, and figured I'd send it over in case it helps you.
The spacing changes here are just some PEP8 stuff. It's not all inclusive, but it got most of it.
The actual change where I needed to modify the script is on line 159. Width and height were being referenced, but they needed to be self._width and self._height.
If this helps, by all means feel free to use it, but don't feel obligated. Just wanted to pass along what helped me.
Thanks for this awesome project!