first implementation of citeproc-ruby #67
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have added more tests, and support for name suffix and -particles. |
|
Many thanks for this @mfenner, it looks great so far. Just to keep you up to speed with immediate plans: we're going to cut a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first implementation of
citeproc-rubyinruby-cff. This pull request also adds support for three citation styles (apa, harvard, ieee), includes their citationstyles.csl, and adopts the existing tests.This pull request addresses #64.
While this is working in principle, more work is needed to map all CFF properties to citeproc.json, fix all failing tests, add more tests for utility methods, checks that one of the included styles is used, etc.