accept filename argument in vm iso/img commands #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sometimes the filename cannot be easily discovered from the basename of the URL, such as when the file is determined by URL params (such as when direct downloading a Google drive file). This commit allows the use of a -f command on the iso and img commands to let the user specify the filename of the fetched file: ``` vm iso -f newfilename.iso 'https://drive.google.com/uc?export=download&confirm=t&id=1DVsS6...HEf0sb' ``` This results in a sensible name instead of "uc?export=download&confirm=t"
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sometimes the filename cannot be easily discovered from the basename of the URL, such as when the file is determined by URL params (such as when direct downloading a Google drive file).
This commit allows the use of a -f command on the iso and img commands to let the user specify the filename of the fetched file:
This results in a sensible name instead of "uc?export=download&confirm=t"