Fix/shadowing var #281
Merged
Fix/shadowing var #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9bafa22
to
eb2e396
Compare
Codecov Report
@@ Coverage Diff @@
## master #281 +/- ##
=======================================
Coverage 88.86% 88.86%
=======================================
Files 79 79
Lines 6771 6772 +1
Branches 475 475
=======================================
+ Hits 6017 6018 +1
Misses 279 279
Partials 475 475
|
alumi
reviewed
Jul 19, 2023
alumi
reviewed
Jul 26, 2023
19b0d9a
to
41f4fd1
Compare
alumi
reviewed
Sep 28, 2023
There was a problem hiding this comment.
@niyarin Thank you for addressing the previous points!
I apologize for the request again, but could you please consider if it's possible to further change the names of local bindings to minimize the use of :exclude directives?
I've added comments on three points as examples.
Please take a look at other codes based on the comments' guidance.
I want to emphasize again that :exclude can be used in situations like when it's crucial for the names to match exactly as specified in the documentation.
a5e6da6
to
4186808
Compare
|
I fixed shadowing-var in vcf-validator that recently entered master. |
4186808
to
d462897
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix shadowing variables.
I've fixed what's in the comment (#279 (review) ) here in this PR.
meta-infoofcljam.io.bcf.readerseemed difficult, so I removed it from the check target.versionofcljam.io.bcf.readercould be renamed, but it is also excluded from inspection because the code becomes complicated.