Add explanation to info exception. #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The comment by linter has nothing to do with this code change. |
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
==========================================
- Coverage 88.75% 88.73% -0.03%
==========================================
Files 76 76
Lines 6298 6301 +3
Branches 436 436
==========================================
+ Hits 5590 5591 +1
- Misses 272 274 +2
Partials 436 436
Continue to review full report at Codecov.
|
alumi
reviewed
Jun 3, 2021
src/cljam/io/vcf/util.clj
Outdated
Comment on lines
43
to
46
| (when-not (parser-map k) | ||
| (throw (ex-info (str "Undeclared INFO, " k ".") | ||
| {:info ss}))) | ||
| [(keyword k) ((parser-map k) vs)]))))))))) |
There was a problem hiding this comment.
Suggested change
| (when-not (parser-map k) | |
| (throw (ex-info (str "Undeclared INFO, " k ".") | |
| {:info ss}))) | |
| [(keyword k) ((parser-map k) vs)]))))))))) | |
| (if-let [parser (parser-map k)] | |
| [(keyword k) (parser vs)] | |
| (throw (ex-info (str "Undeclared INFO, " k ".") | |
| {:info ss})))))))))))) |
niyarin
force-pushed
the
feature/add-explanation-to-info-exception
branch
from
b68d66e
to
1b5ce57
Compare
niyarin
force-pushed
the
feature/add-explanation-to-info-exception
branch
from
1b5ce57
to
51d7fcf
Compare
|
Thank you , my code was a bit verbose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added exception information about which INFO key is the problem to make it easier to understand the exception when reading the VCF, such as missing a reserved INFO key.
I've seen type errors during INFO parsing in the past, but I lost the VCF file that caused it, so I didn't add any other checking features this time.Then I had Cljam read some VCF files (known databases and others) and found no other problems, so I'll do the rest when I find them.